Skip to content

chore: use lambda.Runtime.NODEJS_12_X in all tests#12808

Closed
trivikr wants to merge 8 commits intoaws:masterfrom
trivikr:use-lambda-NODEJS_12_X-in-cdk-tests
Closed

chore: use lambda.Runtime.NODEJS_12_X in all tests#12808
trivikr wants to merge 8 commits intoaws:masterfrom
trivikr:use-lambda-NODEJS_12_X-in-cdk-tests

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Feb 1, 2021

Follow-up to #12713

This PR uses lambda.Runtime.NODEJS_12_X in CDK tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2021 •
edited
Loading

@trivikr trivikr force-pushed the use-lambda-NODEJS_12_X-in-cdk-tests branch 3 times, most recently from 7c64c89 to 70fdeef Compare February 1, 2021 22:46
@nija-at nija-at changed the title test: use lambda.Runtime.NODEJS_12_X chore: use lambda.Runtime.NODEJS_12_X in all tests Feb 23, 2021
nija-at
nija-at previously requested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making these changes. Just one comment below.

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 23, 2021
@trivikr trivikr force-pushed the use-lambda-NODEJS_12_X-in-cdk-tests branch from 70fdeef to 430dec5 Compare February 23, 2021 16:44
@mergify mergify bot dismissed nija-at’s stale review February 23, 2021 16:46

Pull request has been modified.

This was referenced Feb 23, 2021
Closed
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 23, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 430dec5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor

jogold commented Feb 24, 2021

Why not go directly for NODEJS_14_X?

@nija-at
Copy link
Contributor

nija-at commented Feb 25, 2021 •
edited
Loading

Why not go directly for NODEJS_14_X?

I believe CloudFormation does not yet support inline code for Node 14.
As of 2 weeks ago, this still seems to be the case - aws-cloudformation/cloudformation-coverage-roadmap#80 (comment)

(I've not tested this personally)

nija-at
nija-at suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look at the build failures? Looks like there are more changes to be made in the tests.

You will also need to address the merge conflicts :(

Ping me when it's ready and I'll try to ship it before any further merge conflicts arise.

@iliapolo iliapolo mentioned this pull request Mar 9, 2021
Merged
@trivikr
Copy link
Member Author

trivikr commented Apr 12, 2021

Packaged custom resources were moved to nodejs 14.x in #13488

@trivikr trivikr closed this Apr 12, 2021
@trivikr trivikr deleted the use-lambda-NODEJS_12_X-in-cdk-tests branch August 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nija-at nija-at nija-at requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

@aws-cdk/aws-lambda Related to AWS Lambda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trivikr @aws-cdk-automation @jogold @nija-at